Cleanup

Recipes

• Avoid System.exit in library code
• Avoid empty catch blocks
• Encapsulate public mutable fields
• Ensure Log4j is patched against CVE-2021-44228
• Externalize hardcoded credentials
• Externalize hardcoded timeouts
• Extract magic numbers to named constants
• Inventory Typesafe Config usage
• Inventory scala-logging usage
• Keep classes small (max 30 members)
• Keep methods short (max 20 statements)
• Prefer Option over null
• Prefer Scala-style property access over Java getters
• Prefer explicit imports over wildcards
• Prefer immutable collections
• Prefer pattern matching over asInstanceOf casts
• Prefer pattern matching over isInstanceOf/asInstanceOf chains
• Prefer specific types over Any
• Prefer string interpolation over concatenation
• Prefer val over var
• Reduce deep nesting by extracting methods
• Reduce parameter count (max 5 parameters)
• Remove explicit return statements
• Remove redundant toString on String
• Remove unnecessary : Unit return type
• Remove unused variable bindings
• Replace .getOrElse(null) with .orNull
• Replace JavaConverters with CollectionConverters
• Replace unnecessary intermediate collection before .toSet
• Resolve TODO/FIXME comments
• Review deprecated API declarations
• Simplify boolean expression
• Use Option safely
• Use logging framework instead of printStackTrace
• Use logging framework instead of println