Skip to main content
Moderne OnlyThis recipe is proprietary to Moderne and runs on the Moderne platform or CLI — it isn’t part of the open-source catalog. Available with a Moderne subscription.Contact Sales

Find code smells

Recipe IDio.moderne.prethink.quality.FindCodeSmells
Artifactio.moderne.recipe:rewrite-prethink

Detect code smells including God Class, Feature Envy, and Data Class using composite metric thresholds with severity ratings.

Single recipeOpenRewriteModerne Proprietary License
Try in PlatformTry this recipe in the Moderne platform. Not a user yet? You’ll get a no-setup demo environment, with nothing to install or configure.

Examples

Example 1
Unchanged
package com.example;

/**
* Intentionally bloated class to trigger God Class detection.
* WMC >= 47 (each method has if/else = CC 2, 24 methods = WMC 48).
* TCC < 0.33 (each method accesses a different field).
* ATFD > 5 (methods directly access public fields of Other).
*/
public class BigService {
private int f1;
private int f2;
private int f3;
private int f4;
private int f5;
private int f6;
private int f7;
private int f8;
private int f9;
private int f10;
private int f11;
private int f12;
private int f13;
private int f14;
private int f15;
private int f16;
private int f17;
private int f18;
private int f19;
private int f20;
private int f21;
private int f22;
private int f23;
private int f24;

public int method1(Other ext) {
if (ext.x > 0) { return ext.y; }
return f1;
}
public int method2(Other ext) {
if (ext.y > 0) { return ext.z; }
return f2;
}
public int method3(Other ext) {
if (ext.z > 0) { return ext.w; }
return f3;
}
public int method4(Other ext) {
if (ext.w > 0) { return ext.v; }
return f4;
}
public int method5(Other ext) {
if (ext.v > 0) { return ext.u; }
return f5;
}
public int method6(Other ext) {
if (ext.u > 0) { return ext.t; }
return f6;
}
public int method7(Other ext) {
if (ext.x > 0) { return ext.y; }
return f7;
}
public int method8(Other ext) {
if (ext.y > 0) { return ext.z; }
return f8;
}
public int method9(Other ext) {
if (ext.z > 0) { return ext.w; }
return f9;
}
public int method10(Other ext) {
if (ext.w > 0) { return ext.v; }
return f10;
}
public int method11(Other ext) {
if (ext.v > 0) { return ext.u; }
return f11;
}
public int method12(Other ext) {
if (ext.u > 0) { return ext.t; }
return f12;
}
public int method13(Other ext) {
if (ext.x > 0) { return ext.y; }
return f13;
}
public int method14(Other ext) {
if (ext.y > 0) { return ext.z; }
return f14;
}
public int method15(Other ext) {
if (ext.z > 0) { return ext.w; }
return f15;
}
public int method16(Other ext) {
if (ext.w > 0) { return ext.v; }
return f16;
}
public int method17(Other ext) {
if (ext.v > 0) { return ext.u; }
return f17;
}
public int method18(Other ext) {
if (ext.u > 0) { return ext.t; }
return f18;
}
public int method19(Other ext) {
if (ext.x > 0) { return ext.y; }
return f19;
}
public int method20(Other ext) {
if (ext.y > 0) { return ext.z; }
return f20;
}
public int method21(Other ext) {
if (ext.z > 0) { return ext.w; }
return f21;
}
public int method22(Other ext) {
if (ext.w > 0) { return ext.v; }
return f22;
}
public int method23(Other ext) {
if (ext.v > 0) { return ext.u; }
return f23;
}
public int method24(Other ext) {
if (ext.u > 0) { return ext.t; }
return f24;
}
}

Usage

Run this recipe

This recipe has no required configuration options. Users of Moderne can run it via the Moderne CLI.

You will need to have configured the Moderne CLI on your machine before you can run the following command.

shell
mod run . --recipe FindCodeSmells

If the recipe is not available locally, then you can install it using:

mod config recipes jar install io.moderne.recipe:rewrite-prethink:0.8.1

Data tables

Code smells
io.moderne.prethink.table.CodeSmells

Detected code smells including God Class, Feature Envy, and Data Class with severity ratings and the metric evidence that triggered detection.

ColumnDescription
Source pathThe path to the source file containing the smell.
Class nameThe fully qualified name of the class.
Method nameThe method name, if the smell is method-level (e.g., Feature Envy). Null for class-level smells.
Smell typeThe type of code smell: GOD_CLASS, FEATURE_ENVY, or DATA_CLASS.
SeveritySeverity based on how far metrics exceed thresholds: LOW, MEDIUM, HIGH, or CRITICAL.
EvidenceThe metric values that triggered detection, e.g., 'WMC=52, TCC=0.21, ATFD=8'.
Source files that had results
org.openrewrite.table.SourcesFileResults

Source files that were modified by the recipe run.

ColumnDescription
Source path before the runThe source path of the file before the run. null when a source file was created during the run.
Source path after the runA recipe may modify the source path. This is the path after the run. null when a source file was deleted during the run.
Parent of the recipe that made changesIn a hierarchical recipe, the parent of the recipe that made a change. Empty if this is the root of a hierarchy or if the recipe is not hierarchical at all.
Recipe that made changesThe specific recipe that made a change.
Estimated time savingAn estimated effort that a developer to fix manually instead of using this recipe, in unit of seconds.
CycleThe recipe cycle in which the change was made.
Source files that had search results
org.openrewrite.table.SearchResults

Search results that were found during the recipe run.

ColumnDescription
Source path of search result before the runThe source path of the file with the search result markers present.
Source path of search result after run the runA recipe may modify the source path. This is the path after the run. null when a source file was deleted during the run.
ResultThe trimmed printed tree of the LST element that the marker is attached to.
DescriptionThe content of the description of the marker.
Recipe that added the search markerThe specific recipe that added the Search marker.
Source files that errored on a recipe
org.openrewrite.table.SourcesFileErrors

The details of all errors produced by a recipe run.

ColumnDescription
Source pathThe file that failed to parse.
Recipe that made changesThe specific recipe that made a change.
Stack traceThe stack trace of the failure.
Recipe performance
org.openrewrite.table.RecipeRunStats

Statistics used in analyzing the performance of recipes.

ColumnDescription
The recipeThe recipe whose stats are being measured both individually and cumulatively.
Source file countThe number of source files the recipe ran over.
Source file changed countThe number of source files which were changed in the recipe run. Includes files created, deleted, and edited.
Cumulative scanning time (ns)The total time spent across the scanning phase of this recipe.
Max scanning time (ns)The max time scanning any one source file.
Cumulative edit time (ns)The total time spent across the editing phase of this recipe.
Max edit time (ns)The max time editing any one source file.