Spring

Composite Recipes

Recipes that include further recipes, often including the individual recipes below.

• Find Mono/Flux ergonomic smells
• Find Spring Boot bootstrapping smells
• Find Spring Data / repository access smells
• Find Spring Data smells
• Find Spring Web / WebFlux smells
• Find Spring annotation-shape smells
• Find Spring configuration smells
• Find Spring coroutine-migration candidates
• Find Spring dependency-injection smells
• Find Spring legacy / deprecated API smells
• Find Spring proxied-annotation smells
• Find Spring testing smells
• Find WebClient / RestTemplate / ResponseEntity smells
• Find reactive / coroutine interop hazards
• Modernize Spring Boot Kotlin code

Recipes

• Find @Async methods on classes that aren't open
• Find @Async on private functions
• Find @Autowired lateinit var Logger fields
• Find @Autowired lateinit var field injection
• Find @Autowired lateinit var properties (ctor-injection candidate)
• Find @Autowired on a single constructor
• Find @Autowired val field declarations (not in ctor)
• Find @Autowired var properties (not lateinit)
• Find @Bean fun foo(): X = X() candidates for the beans \{ \} DSL
• Find @Bean methods without @Scope
• Find @Cacheable on private functions
• Find @Component / @Service / @Repository on data class
• Find @ConfigurationProperties classes that aren't data class
• Find @Controller classes whose methods all return data (consider @RestController)
• Find @EnableWebMvc on a Spring Boot application
• Find @Entity classes with var properties only
• Find @Entity data class declarations (verify kotlin-jpa plugin)
• Find @EventListener methods with non-Unit return types
• Find @GetMapping/@PostMapping/... methods returning Mono<T>
• Find @Inject lateinit var field injection
• Find @Lazy annotations on @Autowired properties
• Find @MockBean on lateinit var fields
• Find @PathVariable parameters without an explicit name
• Find @PostMapping methods missing @ResponseStatus(HttpStatus.CREATED)
• Find @PropertySource on classes that lack @Configuration
• Find @Qualifier on lateinit var fields
• Find @RequestBody on primitive parameters
• Find @RequestMapping(...) without an HTTP method
• Find @RequestMapping(method = [RequestMethod.GET]) candidates for @GetMapping
• Find @Required annotations
• Find @RestController methods returning ResponseEntity<T>
• Find @Service object Foo declarations
• Find @SpyBean on lateinit var fields
• Find @Transactional methods on classes that aren't open
• Find @Transactional on private functions
• Find @Value on lateinit var properties
• Find Environment.getProperty(...) calls
• Find Flux.blockFirst() calls outside @Test methods
• Find Flux.blockLast() calls outside @Test methods
• Find Flux.flatMap \{ x -> Mono.just(f(x)) \} patterns
• Find Flux.fromIterable(listOf(...)) patterns
• Find Flux.subscribe \{ ... \} without an error consumer
• Find HttpServletRequest parameters in controllers
• Find MockMvcBuilders.standaloneSetup(...) calls
• Find Mono.block / Flux.blockFirst / Flux.blockLast calls
• Find Mono.block() calls in non-test code
• Find Mono.block() calls outside @Test methods
• Find Mono.deferContextual \{ ... \} inside suspend fun
• Find Mono.flatMap \{ x -> Mono.just(f(x)) \} patterns
• Find Mono.zip(...) calls
• Find ResponseEntity(body, HttpStatus.OK) constructor calls
• Find RestTemplate allocations
• Find Spring Data repository methods returning Optional<T>
• Find Spring stereotype classes not declared open
• Find SpringApplication.run(MyApp::class.java, ...) calls
• Find WebClient.bodyToMono(X::class.java) calls
• Find WebClient.create() / WebClient.create(url) calls
• Find WebTestClient test classes that don't use StepVerifier
• Find any lateinit var injected field (@Autowired / @Inject / @Value)
• Find findByIdOrNull(id!!) calls
• Find mono.awaitSingle() calls inside Flux/Flow collectors
• Find repo.findById(id).get() chains
• Find repository interfaces extending CrudRepository instead of JpaRepository
• Find throw ... statements inside Mono/Flux operator lambdas
• Find top-level main functions wrapping SpringApplication.run
• Find webClient...bodyToMono(X::class).block() chains