Functional

Composite Recipes

Recipes that include further recipes, often including the individual recipes below.

• Find Result<T> API ergonomics opportunities
• Find nullability idiom opportunities
• Find raw try/catch smells
• Find runCatching \{ \} smells
• Find throw/catch shape smells
• Modernize Kotlin functional / Result ergonomics

Recipes

• Find .getOrThrow() calls on a Result<T>
• Find Result.getOrElse \{ \} whose lambda ignores the failure parameter
• Find Result.map \{ \}.getOrThrow() chains
• Find broad catch (e: Exception) / catch (e: Throwable) clauses
• Find catch (e: Exception) clauses whose body never references e
• Find catch (e: Exception) \{ throw OtherException(...) \} without e as cause
• Find catch (e: Exception) \{ throw e \} patterns
• Find e.printStackTrace() calls inside a catch block
• Find empty catch blocks
• Find if (predicate(x)) x else null patterns
• Find if (result.isSuccess) … else … patterns
• Find if (x != null) f(x) else null patterns
• Find if (x != null) x else default patterns
• Find if (x == null) throw IllegalArgumentException(...) patterns
• Find if (x == null) throw IllegalStateException(...) patterns
• Find non-empty catch blocks that neither log nor rethrow
• Find runCatching \{ \} blocks that may swallow CancellationException
• Find runCatching \{ \} calls whose result is discarded
• Find runCatching \{ \}.getOrNull() chains
• Find runCatching \{ \}.onFailure \{ log… \} chains with no further handling
• Find runCatching \{ \}.onSuccess \{ … \} chains with no failure handler
• Find throw RuntimeException(e) inside a catch block
• Find try \{ x \} catch (e: Exception) \{ default \} patterns
• Find try \{ x \} catch (e: Exception) \{ null \} patterns
• Find try \{ \} catch \{ \} nested inside another try \{ \} catch \{ \}