Skip to main content

Find Apache Commons BeanUtils property assignments

org.openrewrite.java.security.search.FindBeanPropertyAssignment

Finds calls to Apache Commons BeanUtils and PropertyUtils setters and bulk-copy methods (setProperty, populate, copyProperties, copyProperty, setNestedProperty, setSimpleProperty, setIndexedProperty, setMappedProperty) — including the equivalent instance-method forms on BeanUtilsBean and PropertyUtilsBean, and on any subclass of those, regardless of how the bean instance is obtained (getInstance(), new, injected field, etc.). When the property name or value flows from an untrusted source (e.g. HTTP request parameters), these calls enable bean-injection / mass-assignment (CWE-915) — an attacker can set any settable field on the bean, including ones the application never intended to expose. Per Sonar S4512 each call site needs human review for whether the property name and value come from trusted input. Detector only; does not modify code.

Tags

Recipe source

This recipe is only available to users of Moderne.

This recipe is available under the Moderne Proprietary License.

Example

Before
import org.apache.commons.beanutils.BeanUtils;

class A {
void apply(Object bean, String name, Object value) throws Exception {
BeanUtils.setProperty(bean, name, value);
}
}
After
import org.apache.commons.beanutils.BeanUtils;

class A {
void apply(Object bean, String name, Object value) throws Exception {
/*~~(Setting bean properties from external input can enable bean injection (CWE-915). Verify the property name and value come from a trusted source.)~~>*/BeanUtils.setProperty(bean, name, value);
}
}

Usage

This recipe has no required configuration options. Users of Moderne can run it via the Moderne CLI.

You will need to have configured the Moderne CLI on your machine before you can run the following command.

shell
mod run . --recipe FindBeanPropertyAssignment

If the recipe is not available locally, then you can install it using:

mod config recipes jar install org.openrewrite.recipe:rewrite-java-security:3.33.1

See how this recipe works across multiple open-source repositories

Run this recipe on OSS repos at scale with the Moderne SaaS.

The community edition of the Moderne platform enables you to easily run recipes across thousands of open-source repositories.

Please contact Moderne for more information about safely running the recipes on your own codebase in a private SaaS.

Data Tables

Source files that had results

org.openrewrite.table.SourcesFileResults

Source files that were modified by the recipe run.

Column NameDescription
Source path before the runThe source path of the file before the run. null when a source file was created during the run.
Source path after the runA recipe may modify the source path. This is the path after the run. null when a source file was deleted during the run.
Parent of the recipe that made changesIn a hierarchical recipe, the parent of the recipe that made a change. Empty if this is the root of a hierarchy or if the recipe is not hierarchical at all.
Recipe that made changesThe specific recipe that made a change.
Estimated time savingAn estimated effort that a developer to fix manually instead of using this recipe, in unit of seconds.
CycleThe recipe cycle in which the change was made.