Open source

Adds a TimeUnit argument to the matched method invocations

Recipe IDorg.openrewrite.apache.httpclient5.AddTimeUnitArgument

Artifactorg.openrewrite.recipe:rewrite-apache

In Apache Http Client 5.x migration, an extra TimeUnit argument is required in the timeout and duration methods. Previously in 4.x, all these methods were implicitly having the timeout or duration expressed in milliseconds, but in 5.x the unit of the timeout or duration is required. So, by default this recipe adds TimeUnit.MILLISECONDS, it is possible to specify this as a parameter. Since all affected methods of the Apache Http Client 5.x migration only have one integer/long argument, the recipe applies with matched method invocations of exactly one parameter.

Single recipeOpenRewriteModerne Source Available License

Try in PlatformTry this recipe in the Moderne platform. Not a user yet? You’ll get a no-setup demo environment, with nothing to install or configure.

Options

2 parameters

1 required1 optional

Parameter	Example	Type	Required
methodPattern	org.apache.http.client.config.RequestConfig.Builder setConnectionRequestTimeout(int)	String	Required
A method pattern that is used to find matching method invocations.
timeUnit	MILLISECONDS	TimeUnit	Optional
The TimeUnit enum value we want to add to the method invocation. Defaults to MILLISECONDS.

Examples

java

Parameter	Value
methodPattern	A method(int)
timeUnit	null

java

Before

class B {
    void test() {
        A a = new A();
        a.method(100);
    }
}

After

import java.util.concurrent.TimeUnit;

class B {
    void test() {
        A a = new A();
        a.method(100, TimeUnit.MILLISECONDS);
    }
}

Diff

@@ -1,0 +1,2 @@
+import java.util.concurrent.TimeUnit;
+
class B {
@@ -4,1 +6,1 @@
    void test() {
        A a = new A();
-       a.method(100);
+       a.method(100, TimeUnit.MILLISECONDS);
    }

Usage

Run this recipe

You will need to have configured the Moderne CLI on your machine before you can run the following command.

shell

mod run . --recipe AddTimeUnitArgument --recipe-option "methodPattern=org.apache.http.client.config.RequestConfig.Builder setConnectionRequestTimeout(int)" --recipe-option "timeUnit=MILLISECONDS"

If the recipe is not available locally, then you can install it using:

mod config recipes jar install org.openrewrite.recipe:rewrite-apache:2.27.1

Data tables

Source files that had results

org.openrewrite.table.SourcesFileResults

Source files that were modified by the recipe run.

Column	Description
Source path before the run	The source path of the file before the run. null when a source file was created during the run.
Source path after the run	A recipe may modify the source path. This is the path after the run. null when a source file was deleted during the run.
Parent of the recipe that made changes	In a hierarchical recipe, the parent of the recipe that made a change. Empty if this is the root of a hierarchy or if the recipe is not hierarchical at all.
Recipe that made changes	The specific recipe that made a change.
Estimated time saving	An estimated effort that a developer to fix manually instead of using this recipe, in unit of seconds.
Cycle	The recipe cycle in which the change was made.

Source files that had search results

org.openrewrite.table.SearchResults

Search results that were found during the recipe run.

Column	Description
Source path of search result before the run	The source path of the file with the search result markers present.
Source path of search result after run the run	A recipe may modify the source path. This is the path after the run. null when a source file was deleted during the run.
Result	The trimmed printed tree of the LST element that the marker is attached to.
Description	The content of the description of the marker.
Recipe that added the search marker	The specific recipe that added the Search marker.

Source files that errored on a recipe

org.openrewrite.table.SourcesFileErrors

The details of all errors produced by a recipe run.

Column	Description
Source path	The file that failed to parse.
Recipe that made changes	The specific recipe that made a change.
Stack trace	The stack trace of the failure.

Recipe performance

org.openrewrite.table.RecipeRunStats

Statistics used in analyzing the performance of recipes.

Column	Description
The recipe	The recipe whose stats are being measured both individually and cumulatively.
Source file count	The number of source files the recipe ran over.
Source file changed count	The number of source files which were changed in the recipe run. Includes files created, deleted, and edited.
Cumulative scanning time (ns)	The total time spent across the scanning phase of this recipe.
Max scanning time (ns)	The max time scanning any one source file.
Cumulative edit time (ns)	The total time spent across the editing phase of this recipe.
Max edit time (ns)	The max time editing any one source file.